[
https://issues.apache.org/jira/browse/CALCITE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712455#comment-17712455
]
Stamatis Zampetakis commented on CALCITE-5615:
----------------------------------------------
[~mbudiu] As far as I understand this new module is not really bound to
Calcite. It is a general executor that can run SQL logic tests in any JDBC
compliant system. In fact the Calcite specific code could be isolated in maybe
one or two classes. Wouldn't it be more appropriate to contribute this module
under the SQL logic repo or possibly another Apache (e.g.,
https://db.apache.org/) project and put in Calcite only extensions that are
really relevant to the project?
We definitely want to have more test coverage for Calcite but the way the PR
looks right now it seems that we are publishing a new SQL logic executor under
the org.apache.calcite namespace. Please correct me if I misunderstood
something.
If my understanding is correct then we probably need to have a broader
discussion in the dev@ list to see if other members of the project are OK to
host the SQL logic executor code here. Please start a DISCUSS thread in the
dev@ list if that's the case.
> Run SQLLogicTests using Calcite
> -------------------------------
>
> Key: CALCITE-5615
> URL: https://issues.apache.org/jira/browse/CALCITE-5615
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Sqllogictest is a program designed to verify that an SQL database engine
> computes correct results by comparing the results to identical queries from
> other SQL database engines.
> https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki
> The nice thing about SLT is that it contains more than 7 million tests. The
> tests only cover the core of SQL, ideally the portable part across all
> engines. They only test integers, doubles, and strings. So they could
> probably be part of the Calcite slow tests.
> The tests should be structured so that any query execution engine can be used.
> I plan to contribute such an implementation if people think it is useful, but
> I haven't yet worked out all the details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
