[
https://issues.apache.org/jira/browse/CALCITE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713465#comment-17713465
]
Stamatis Zampetakis commented on CALCITE-5615:
----------------------------------------------
I'm fine having it as new module in Calcite I just wanted other members in the
PMC to be aware and OK with this change. There wasn't any push-back in the
DISCUSS thread so I think we could move on towards this direction.
It will certainly require a few more review iterations till it gets in but if
that's OK with everyone we can proceed.
The sqllogictest parser/executor is is going to be "production" code that
Calcite users can download, run, and include in their pipelines so we
definitely want to have some unit tests in the new module. At a bare minimum I
would say that we want tests that call the Main class with the various
supported arguments and ensure that it works as expected.
I am also thinking that since this is a port of sqllogictest in Java we should
try to minimize dependencies (such as to calcite core) so that it can be used
by anyone even from those that have no interest at all to Calcite.
I may find more things once I go again over the PR but I guess they will be
rather minor so will comment directly there.
Let me know what you think and how do you want to proceed.
> Run SQLLogicTests using Calcite
> -------------------------------
>
> Key: CALCITE-5615
> URL: https://issues.apache.org/jira/browse/CALCITE-5615
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Sqllogictest is a program designed to verify that an SQL database engine
> computes correct results by comparing the results to identical queries from
> other SQL database engines.
> https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki
> The nice thing about SLT is that it contains more than 7 million tests. The
> tests only cover the core of SQL, ideally the portable part across all
> engines. They only test integers, doubles, and strings. So they could
> probably be part of the Calcite slow tests.
> The tests should be structured so that any query execution engine can be used.
> I plan to contribute such an implementation if people think it is useful, but
> I haven't yet worked out all the details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
