[
https://issues.apache.org/jira/browse/CALCITE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713421#comment-17713421
]
Julian Hyde commented on CALCITE-5650:
--------------------------------------
The {{dialect(SqlDialect)}} and {{withTypeSystem(RelDataTypeSystem)}} methods
are both 'with-er' methods, so I think the current behavior - each method
assigning just one attribute - is what most people would expect.
Or maybe the {{withTypeSystem(RelDataTypeSystem)}} method should be removed
altogether, and the fixture should always use the type system within the
dialect.
[~zabetak], You added that method in CALCITE-4706. What do you think makes
sense?
> Sql.dialect method in RelToSqlConverterTests ignores dialect type system
> ------------------------------------------------------------------------
>
> Key: CALCITE-5650
> URL: https://issues.apache.org/jira/browse/CALCITE-5650
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.34.0
> Reporter: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The problem is in the file SqlToRelConverterTest.java, in the static class
> Sql, in the following method:
> Sql dialect(SqlDialect dialect) {
> return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet,
> config,
> relFn, transforms, typeSystem);
> }
> The problem is that the dialect may have a different type system, which is
> ignored in this function. I think the function should read:
> Sql dialect(SqlDialect dialect) {
> return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet,
> config,
> relFn, transforms, dialect.getTypeSystem());
> }
> Several tests in this file do change the dialect type system.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
