[
https://issues.apache.org/jira/browse/CALCITE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713694#comment-17713694
]
Mihai Budiu commented on CALCITE-5650:
--------------------------------------
I have added a new commit to my PR which removes the typeSystem field.
https://github.com/apache/calcite/pull/3155/commits/74ad309e3299194cca21259e1c391b759aeb2332
> Sql.dialect method in RelToSqlConverterTests ignores dialect type system
> ------------------------------------------------------------------------
>
> Key: CALCITE-5650
> URL: https://issues.apache.org/jira/browse/CALCITE-5650
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.34.0
> Reporter: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The problem is in the file SqlToRelConverterTest.java, in the static class
> Sql, in the following method:
> Sql dialect(SqlDialect dialect) {
> return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet,
> config,
> relFn, transforms, typeSystem);
> }
> The problem is that the dialect may have a different type system, which is
> ignored in this function. I think the function should read:
> Sql dialect(SqlDialect dialect) {
> return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet,
> config,
> relFn, transforms, dialect.getTypeSystem());
> }
> Several tests in this file do change the dialect type system.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
