[ 
https://issues.apache.org/jira/browse/CALCITE-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715237#comment-17715237
 ] 

Julian Hyde commented on CALCITE-5614:
--------------------------------------

I have reviewed and revised in 
[julianhyde/5614-sarg-json|https://github.com/julianhyde/calcite/tree/5614-sarg-json].
 I improved the test by actually converting to a string, which ensures that all 
objects can be serialized; I moved some of the JSON conversion methods into 
RelJson; and I made more use of RangeSets.Handler for efficiency and 
uniformity. Please let me know what you think.

> Serialize and deserialize Sarg objects
> --------------------------------------
>
>                 Key: CALCITE-5614
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5614
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Oliver Lee
>            Assignee: Oliver Lee
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Context: Bounded filter conditions (e.g. {{{}SUM(field> > 1 AND SUM(field) < 
> 10{}}}) are converted to calls to a [SEARCH 
> operator.|https://github.com/apache/calcite/blob/052a5cc724a889edf19c1d76ea166c0d0924a5d3/core/src/main/java/org/apache/calcite/rex/RexInterpreter.java#L224calls]
>  If this is then serialized and deserialized, it will throw an exception when 
> resolving {{{}SEARCH{}}}.
>  
>  
> To complete this ticket: Add functionality such that {{Sarg}} literals can be 
> serialized and deserialized.
>  
> {{RelJson.java}} should be updated so that {{toRex}} can serialize {{Sarg}} 
> objects
>  
> {{RexBuilder.java}} should be updated to be able to successfully deserialize 
> a JSON string that includes {{Sarg}} literals 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to