[
https://issues.apache.org/jira/browse/CALCITE-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716466#comment-17716466
]
Oliver Lee commented on CALCITE-5614:
-------------------------------------
I've managed to read through all the commits, I do like the use of Handler and
the simplification into {{{}all(){}}}, {{{}atLeast(){}}}, etc.
I don't think I saw how the test is converting to a string in
{{RelWriterTest.java}}
I only see that it's refactored into the {{consumer}} instead of my
{{{}for-loop{}}}, and the uncommenting of the block that is still under {{if
(false)}}
Do you mind pointing me to that?
Everything else looks good and is much cleaner, thanks!
> Serialize and deserialize Sarg objects
> --------------------------------------
>
> Key: CALCITE-5614
> URL: https://issues.apache.org/jira/browse/CALCITE-5614
> Project: Calcite
> Issue Type: Improvement
> Reporter: Oliver Lee
> Assignee: Oliver Lee
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Context: Bounded filter conditions (e.g. {{{}SUM(field> > 1 AND SUM(field) <
> 10{}}}) are converted to calls to a [SEARCH
> operator.|https://github.com/apache/calcite/blob/052a5cc724a889edf19c1d76ea166c0d0924a5d3/core/src/main/java/org/apache/calcite/rex/RexInterpreter.java#L224calls]
> If this is then serialized and deserialized, it will throw an exception when
> resolving {{{}SEARCH{}}}.
>
>
> To complete this ticket: Add functionality such that {{Sarg}} literals can be
> serialized and deserialized.
>
> {{RelJson.java}} should be updated so that {{toRex}} can serialize {{Sarg}}
> objects
>
> {{RexBuilder.java}} should be updated to be able to successfully deserialize
> a JSON string that includes {{Sarg}} literals
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
