[ 
https://issues.apache.org/jira/browse/CALCITE-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757038#comment-17757038
 ] 

Claude Brisson commented on CALCITE-5931:
-----------------------------------------

Thanks for the review.



I changed the PR title, and added a unit test (only one like your second 
proposal, the others don't really fit in the context).

 

> Allow integers like 1.00 in window frame
> ----------------------------------------
>
>                 Key: CALCITE-5931
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5931
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.35.0
>            Reporter: Claude Brisson
>            Priority: Minor
>              Labels: pull-request-available
>
> When a number of rows is specified for a window, the code checks that the 
> provided literal is an integral number.
> But the provided check leaves aside numbers like "1.00" (with a scale of 2, 
> but with trailing zeros).
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to