[ 
https://issues.apache.org/jira/browse/CALCITE-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763309#comment-17763309
 ] 

Jiajun Xie commented on CALCITE-5931:
-------------------------------------

[~cbrisson] , Your PR is already dirty because force-pushed main.

 

I cherry-pick your commit and add test in `winagg.iq`, welcome to review.

[https://github.com/apache/calcite/pull/3413]

 

Let's merge it before the release of version 1.36.

> Allow integers like 1.00 in window frame
> ----------------------------------------
>
>                 Key: CALCITE-5931
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5931
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.35.0
>            Reporter: Claude Brisson
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.36.0
>
>
> When a number of rows is specified for a window, the code checks that the 
> provided literal is an integral number.
> But the provided check leaves aside numbers like "1.00" (with a scale of 2, 
> but with trailing zeros).
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to