[ 
https://issues.apache.org/jira/browse/CALCITE-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759994#comment-17759994
 ] 

Julian Hyde commented on CALCITE-5965:
--------------------------------------

I saw you converted the call to Preconditions.checkArgument into an “if”. Could 
you instead pass a template and arguments to checkArgument? It is as efficient 
as your code and more readable.  Also statically import checkArgument. 

> Avoid unnecessary String concatenations in the RexFieldAccess constructor to 
> improve the performance
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5965
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5965
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Thomas Rebele
>            Assignee: Thomas Rebele
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 1.36.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to