[
https://issues.apache.org/jira/browse/CALCITE-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760278#comment-17760278
]
Thomas Rebele commented on CALCITE-5965:
----------------------------------------
I would call it almost as efficient, as there has to be a certain overhead for
inlining the function call. Probably it does not make a noticeable difference
in practice, so ok. I've updated the PR.
About the static import. I prefer to keep the import as it is. It seems to me
that "Preconditions.checkArgument" is easier to understand than just
"checkArgument". It also seems more common in Calcite to use the former. Here
some stats:
{noformat}
$ rg -l "import com.google.common.base.Preconditions" | wc -l
95
$ rg -l "import static com.google.common.base.Preconditions" | wc -l
19
{noformat}
Maybe such a change should be done in the context of another ticket.
> Avoid unnecessary String concatenations in the RexFieldAccess constructor to
> improve the performance
> ----------------------------------------------------------------------------------------------------
>
> Key: CALCITE-5965
> URL: https://issues.apache.org/jira/browse/CALCITE-5965
> Project: Calcite
> Issue Type: Task
> Reporter: Thomas Rebele
> Assignee: Thomas Rebele
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.36.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
