[ 
https://issues.apache.org/jira/browse/CALCITE-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770866#comment-17770866
 ] 

Runkang He commented on CALCITE-5990:
-------------------------------------

Hi [~uilx744], this issue is related to CALCITE-5921, which means the test 
suite runs but doesn't check runtime failure unexpectedly.


For more useful information about existing tests, you can refer to the document 
[https://calcite.apache.org/docs/howto.html#running-tests]. We can see that not 
every test will be executed after each commit is pushed, but the main test 
suites will.

> Explicit cast to numeric type doesn't check overflow
> ----------------------------------------------------
>
>                 Key: CALCITE-5990
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5990
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.35.0
>            Reporter: Runkang He
>            Assignee: Runkang He
>            Priority: Blocker
>             Fix For: 1.36.0
>
>
> Explicit cast to numeric type doesn't check overflow, and this issue can be 
> reproduced by sqlline:
> {code:sql}
> select cast(empno as tinyint), cast(130 as tinyint) from emps where 
> name='Alice'; -- empno is 130
> {code}
> The empno is INT type. The result is:
> {code:sql}
> -126, -126{code}
> I think it should throw exception when overflow.
> At last, this issue was found when to turn on runtime check for 
> CalciteSqlOperatorTest in CALCITE-5921.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to