[
https://issues.apache.org/jira/browse/CALCITE-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883968#comment-17883968
]
Julian Hyde commented on CALCITE-6465:
--------------------------------------
Regarding linq4j. It's a library, so you want to use it and test it without it
inheriting 'global variables'. The way you've done it in the PR looks just
about ideal. (I would consider changing the property from boolean to an int - a
size limit. I would also consider making the parameter optional, default false;
most of the EnumUtils tests should operate with splitting disabled, because as
unit tests they should only be testing one or two things at a time.)
Ironically, what you are proposing to do to linq4j - make it more than a
library, and with deeper dependencies on the parent project - is exactly what I
fear will happen to flink-table. If it's not called out in the module name that
it is utilities, never (never! never!) to depend on the parent, then someone
will in future introduce a dependency.
> Rework code generator to use Flink code splitter
> ------------------------------------------------
>
> Key: CALCITE-6465
> URL: https://issues.apache.org/jira/browse/CALCITE-6465
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Reporter: James Duong
> Assignee: James Duong
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.38.0
>
>
> Holistically replace the (or provide a separate optional) code generator to
> reduce issues such as CALCITE-3094 .
> One suggestion in the comments for CALCITE-3094 has been to use the [code
> generator from
> Flink.|https://nightlies.apache.org/flink/flink-docs-release-1.3/api/java/org/apache/flink/table/codegen/CodeGenerator.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
