[
https://issues.apache.org/jira/browse/CALCITE-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890942#comment-17890942
]
James Duong commented on CALCITE-6465:
--------------------------------------
Thanks for identifying these scenarios [~xinqiu] .
It seems both of these issues occur when using anonymous inner classes. I'll
bring this up with the Flink team to see if they have any ideas about this.
The way I've integrated JavaCodeSplitter, it takes in the class definition and
can definitely increase class size in exchange for decreasing individual method
sizes (by splitting methods into sub-methods, moving local variables to class
fields, etc). This may not be a good strategy when dealing with anonymous inner
classes since those are often declared within methods.
> Rework code generator to use Flink code splitter
> ------------------------------------------------
>
> Key: CALCITE-6465
> URL: https://issues.apache.org/jira/browse/CALCITE-6465
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Reporter: James Duong
> Assignee: James Duong
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.39.0
>
> Attachments: after_split_01.txt, after_split_02.txt,
> before_split_01.txt, before_split_02.txt
>
>
> Holistically replace the (or provide a separate optional) code generator to
> reduce issues such as CALCITE-3094 .
> One suggestion in the comments for CALCITE-3094 has been to use the [code
> generator from
> Flink.|https://nightlies.apache.org/flink/flink-docs-release-1.3/api/java/org/apache/flink/table/codegen/CodeGenerator.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
