[ 
https://issues.apache.org/jira/browse/CALCITE-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944821#comment-17944821
 ] 

Mihai Budiu commented on CALCITE-6335:
--------------------------------------

yes, plan comparisons will fail. but looking at plans is not a robust test 
anyway, that should be done sparingly, and perhaps left for RelOptRulesTest.

but all optimization rules are supposed to preserve semantics

ideally we would run *all* optimization rules with *all* quidem tests and 
compare the outputs

I will make you a bet that we will find hundreds of bugs this way

We can start with one rule, for "constant folding" PROJECT_REDUCE_EXPRESSIONS

 

> Quidem tests should allow specifying optimization passes to apply to programs
> -----------------------------------------------------------------------------
>
>                 Key: CALCITE-6335
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6335
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.36.0
>            Reporter: Mihai Budiu
>            Assignee: Zhen Chen
>            Priority: Minor
>              Labels: pull-request-available
>
> This facility would make it much easier to test various optimization passes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to