[ 
https://issues.apache.org/jira/browse/CALCITE-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955451#comment-17955451
 ] 

Zhen Chen commented on CALCITE-7016:
------------------------------------

[~asolimando] As I mentioned above, RelNode constructed using relFen cannot be 
converted into standard SQL in all cases. So I have not thought of a good way 
to implement your suggestion. I have looked for a long time and no one has made 
suggestions on this jira. If you think this approach is not appropriate, I will 
close this PR first. If others have a better way, he can continue this jira.

> Sql resources should not be included in XML when using relFn in 
> RelOptRulesTest testing
> ---------------------------------------------------------------------------------------
>
>                 Key: CALCITE-7016
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7016
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Zhen Chen
>            Assignee: Zhen Chen
>            Priority: Minor
>              Labels: pull-request-available
>
> Use relFn to construct a plan for rule validation, and SQL resources should 
> not be included in the result file(RelOptRulesTest.xml). If SQL can be used 
> to generate plans, it is not recommended to use relFn for construction. 
> Otherwise, it may lead to incorrect mapping between sql and planBefore.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to