[
https://issues.apache.org/jira/browse/CALCITE-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955479#comment-17955479
]
Zhen Chen commented on CALCITE-7016:
------------------------------------
[~asolimando] I think there is nothing wrong with what you said, and people who
review the code need to pay attention to it. Then I will temporarily close my
PR.
> Sql resources should not be included in XML when using relFn in
> RelOptRulesTest testing
> ---------------------------------------------------------------------------------------
>
> Key: CALCITE-7016
> URL: https://issues.apache.org/jira/browse/CALCITE-7016
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zhen Chen
> Assignee: Zhen Chen
> Priority: Minor
> Labels: pull-request-available
>
> Use relFn to construct a plan for rule validation, and SQL resources should
> not be included in the result file(RelOptRulesTest.xml). If SQL can be used
> to generate plans, it is not recommended to use relFn for construction.
> Otherwise, it may lead to incorrect mapping between sql and planBefore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
