[ 
https://issues.apache.org/jira/browse/CALCITE-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17980151#comment-17980151
 ] 

Mihai Budiu commented on CALCITE-7058:
--------------------------------------

This being said, it may be a lot of work to remove the assumption about values 
implementing Comparable; it may be baked into lots of parts of the code.

In our implementation we use a completely different backend, by generating Rust 
code. We also require every value to be comparable, and we rely on the Rust Ord 
trait for that purpose. We have yet to find any problem with that approach - 
all the data structures we needed are properly comparable. A nice benefit of 
this is that it also makes results deterministic if you sort.

> Decorrelator may produce different column names
> -----------------------------------------------
>
>                 Key: CALCITE-7058
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7058
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.40.0
>            Reporter: Mihai Budiu
>            Assignee: Mihai Budiu
>            Priority: Minor
>
> In [CALCITE-7024] I have introduced an assertion (Litmus) check in the 
> decorrelator that the output relation type is identical to the input relation 
> type. This assertion is too strong, because the decorrelator sometimes 
> produces different column names in the result.
> This may be a bug, but in the meantime it can be side-stepped by making the 
> check a bit weaker: the types are identical up to column names.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to