[
https://issues.apache.org/jira/browse/CALCITE-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18033170#comment-18033170
]
Stamatis Zampetakis commented on CALCITE-7243:
----------------------------------------------
I do see the problem and its probably an incomplete implementation from
CALCITE-2201 and CALCITE-3111. Both changes attempt to make the decorrelator
more general but failed to cover all paths.
I do agree with Mihai though that in order to fix this we need to implement
some tests somewhere that showcase the problem and prove that it is fixed.
> Rules in RelDecorrelator not using config of RelBuilder passed in
> -----------------------------------------------------------------
>
> Key: CALCITE-7243
> URL: https://issues.apache.org/jira/browse/CALCITE-7243
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Steve Carlin
> Priority: Major
>
> So I think this is a bug, but I'm not sure I have a complete understanding of
> the code.
> One rule used in RelDecorrelator is on this line:
> [https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java#L296]
> Here, it uses the rule with what seemingly is the RelBuilder that is passed
> into the RelDecorrelator as shown in this line:
> [https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java#L281]
> I think the problem is that the RelBuilder needs a Context or a Factory
> passed in. It doesn't seem meant to handle a RelBuilder itself?
> Not sure how to fix this, but I hit this problem when I needed to use my own
> RelBuilder containing a value within my RelBuilder.Config, and it was not
> using my RelBuilder in this rule.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
