[
https://issues.apache.org/jira/browse/CALCITE-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18033364#comment-18033364
]
Steve Carlin commented on CALCITE-7243:
---------------------------------------
So I don't have a specific problem. I only logged this because if I'm reading
the code correctly, it's a line that is just wrong. While testing, I noticed
it wasn't picking up my config, but it wasn't a big deal to me.
I'm leary about closing the issue because [~zabetak] confirmed it is wrong, but
yeah I don't have a use case to prove that it's wrong. I can prolly create a
unit test to do this, but it wouldn't necessarily be a real world use case.
But that's not really worth my time since no one (including myself) is
complaining about this, I have enough real world problems to work on.
Do you want to close this as "Will Not Fix"? I mean, I'm ok with that. Or
just keep it open? For future reference, should I not file issues like this?
> Rules in RelDecorrelator not using config of RelBuilder passed in
> -----------------------------------------------------------------
>
> Key: CALCITE-7243
> URL: https://issues.apache.org/jira/browse/CALCITE-7243
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Steve Carlin
> Priority: Major
>
> So I think this is a bug, but I'm not sure I have a complete understanding of
> the code.
> One rule used in RelDecorrelator is on this line:
> [https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java#L296]
> Here, it uses the rule with what seemingly is the RelBuilder that is passed
> into the RelDecorrelator as shown in this line:
> [https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java#L281]
> I think the problem is that the RelBuilder needs a Context or a Factory
> passed in. It doesn't seem meant to handle a RelBuilder itself?
> Not sure how to fix this, but I hit this problem when I needed to use my own
> RelBuilder containing a value within my RelBuilder.Config, and it was not
> using my RelBuilder in this rule.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
