[ 
https://issues.apache.org/jira/browse/CALCITE-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206854#comment-14206854
 ] 

Vladimir Sitnikov commented on CALCITE-460:
-------------------------------------------

That's a big change.

{code:sql}
+    if (builder.wouldEqual(bitSet)) {
+      return bitSet;
+    }
+    return builder.build();
{code}

What if {{Builder(ImmutableBitSet)}} remembers the input bitset and returns 
that in the build method if the result is the same?


> Add ImmutableBitSet and replace uses of BitSet
> ----------------------------------------------
>
>                 Key: CALCITE-460
>                 URL: https://issues.apache.org/jira/browse/CALCITE-460
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> Calcite makes heavy use of bit sets. java.util.BitSet has a convenient API 
> but (a) is mutable, (b) uses quite a lot of memory, (c) is not iterable.
> Propose to implement ImmutableBitSet, which addresses those deficiencies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to