[jira] [Commented] (CALCITE-460) Add ImmutableBitSet and replace uses of BitSet

[Julian Hyde (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CALCITE-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207030#comment-14207030
 ] 

Julian Hyde commented on CALCITE-460:
-------------------------------------

I'm adding

{code}
    public ImmutableBitSet build(ImmutableBitSet bitSet) {
      if (wouldEqual(bitSet)) {
        return bitSet;
      }
      return build();
    }
{code}

using it in several places, and making wouldEqual private. Keeps the onus on 
the client rather than Builder to remember the original bit set.

> Add ImmutableBitSet and replace uses of BitSet
> ----------------------------------------------
>
>                 Key: CALCITE-460
>                 URL: https://issues.apache.org/jira/browse/CALCITE-460
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> Calcite makes heavy use of bit sets. java.util.BitSet has a convenient API 
> but (a) is mutable, (b) uses quite a lot of memory, (c) is not iterable.
> Propose to implement ImmutableBitSet, which addresses those deficiencies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)