[ 
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562588#comment-14562588
 ] 

YeongWei commented on CALCITE-705:
----------------------------------

Hi [~julianhyde]

I have amended my implementation and the current work-in-progress can be found 
at,

https://github.com/yeongwei/incubator-calcite/commit/ae2aa52508d027e8f42f47af98b7a5be0c741f6b?diff=split

Feel free to take a look.

There are 3 Unit tests that may be worth to run,
1. CalciteRemoteDriverTest#testInsert - Test insert operation remotely via 
CalciteMetaImpl
2. JdbcFrontLinqBackTest#testInsert3 - Test insert with Calcite local connection
3. RemoteDriverTest#testCreateInsertUpdateDrop - Previously pointed out by you

Further thoughts,
1. It seems that it is worth while to put Meta.Signature / CalciteSignature 
into AvaticaStatement instead of AvaticaPreparedStatement
2. WIth #1, we may attempt to do a AvaticaStatement#setSignature during 
prepareCallback#assign then use it during the prepareCallback#execute

Let me know your thoughts.

Thanks!

> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
>                 Key: CALCITE-705
>                 URL: https://issues.apache.org/jira/browse/CALCITE-705
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: YeongWei
>            Assignee: Julian Hyde
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to