[
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569892#comment-14569892
]
Julian Hyde commented on CALCITE-705:
-------------------------------------
Looks pretty good.
Can you remove Meta.StatementType.UPDATE_CAPABLE? I don't like the idea of a
mutable list. How about
{code}
enum StatementType {
...
public boolean canUpdate() {
switch (this) {
case INSERT:
return true;
default:
return false;
}
}
{code}
In Signature, make statementType public, mandatory and final. If you don't
know, assume SELECT. Modify the existing constructors for Signature and
CalciteSignature, don't add new ones.
In LocalService, don't assume that the count is a Long. Just assume that it is
a Number, and call Number.intValue().
> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
> Key: CALCITE-705
> URL: https://issues.apache.org/jira/browse/CALCITE-705
> Project: Calcite
> Issue Type: New Feature
> Reporter: YeongWei
> Assignee: Julian Hyde
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
