[jira] [Commented] (CALCITE-705) AvaticaStatement execute method to support DML

[YeongWei (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944951#comment-14944951
 ] 

YeongWei commented on CALCITE-705:
----------------------------------

Hi [~elserj]

I needed to add new schema into the requests.proto as below,
{code}
// Request for Meta#execute(Meta.ConnectionHandle, list, long)
message ExecuteRequest {
  uint32 statement_id = 1;
  repeated TypedValue parameter_values = 2;
  uint64 offset = 3;
}
{code}

Then I proceeded with the,
{code}
$ cd avatica 
$ ./src/main/scripts/generate-protobuf.sh
{code}

However, Eclipse is unable to compile, then I proceed to inspected the 
generated codes but found out that there are a lot differences as compared to 
master, example as below,
{code}
-    private ExecuteResponse(com.google.protobuf.GeneratedMessage.Builder 
builder) {
+    private ExecuteResponse(com.google.protobuf.GeneratedMessage.Builder<?> 
builder) {
       super(builder);
     }
     private ExecuteResponse() {
@@ -1090,8 +1102,7 @@ private ExecuteResponse() {
     }
     private ExecuteResponse(
         com.google.protobuf.CodedInputStream input,
-        com.google.protobuf.ExtensionRegistryLite extensionRegistry)
-        throws com.google.protobuf.InvalidProtocolBufferException {
+        com.google.protobuf.ExtensionRegistryLite extensionRegistry) {
       this();
       int mutable_bitField0_ = 0;
       try {

     public static org.apache.calcite.avatica.proto.Responses.ResultSetResponse 
getDefaultInstance() {
-      return defaultInstance;
+      return DEFAULT_INSTANCE;
+    }

{code}
Especially on the exceptions that most should be throwing the RuntimeException

Below is my protoc version,
{code}
root@sherpa:/opt/java# cd ~
root@sherpa:~# which protoc
/usr/local/bin/protoc
root@sherpa:~# /usr/local/bin/protoc --version
libprotoc 3.0.0
root@sherpa:~# 
{code}

Did I miss something anywhere?

Thanks!

> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
>                 Key: CALCITE-705
>                 URL: https://issues.apache.org/jira/browse/CALCITE-705
>             Project: Calcite
>          Issue Type: New Feature
>          Components: avatica
>            Reporter: YeongWei
>            Assignee: Julian Hyde
>             Fix For: next
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)