[
https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952370#comment-14952370
]
Josh Elser commented on CALCITE-705:
------------------------------------
bq. Previously, on JDBC the finagle method did the job of handling the types
properly. Let me know what do you think.
Hrm, I don't remember with certainty now, but I'm guessing I didn't do this in
finagle in hopes to prevent yet-another-copy of a byte array (although doing
this translation in the `finagle`s would be a more sensible place to do this).
Location aside, your change looks reasonable. Could potentially do an
instanceof check instead of making two assumptions as to the "type" of bytes
({{byte[]}} or {{ByteString}}).
> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
> Key: CALCITE-705
> URL: https://issues.apache.org/jira/browse/CALCITE-705
> Project: Calcite
> Issue Type: New Feature
> Components: avatica
> Reporter: YeongWei
> Assignee: Julian Hyde
> Fix For: next
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
