[
https://issues.apache.org/jira/browse/CAMEL-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259244#comment-13259244
]
Richard Kettelerij commented on CAMEL-5155:
-------------------------------------------
Hi Woonsan,
I've had a look at your patch and noticed you're starting a new thread in the
{{JcrConsumer}} class. When starting new threads in Camel it's advisable to use
the
[ExecutorServiceManager|http://camel.apache.org/maven/current/camel-core/apidocs/org/apache/camel/spi/ExecutorServiceManager.html].
This allows users to plugin different threading implementation (e.g. JCA
WorkManager or CommonJ).
One minor detail: the try/catch in JcrMessage.toString() isn't necessary.
Kind regards,
Richard
> Support JCR Component as Consumer
> ---------------------------------
>
> Key: CAMEL-5155
> URL: https://issues.apache.org/jira/browse/CAMEL-5155
> Project: Camel
> Issue Type: New Feature
> Components: camel-jcr
> Affects Versions: 2.9.1
> Reporter: Woonsan Ko
> Assignee: Bilgin Ibryam
> Fix For: 2.10.0
>
> Attachments: jcr-consumer-patch.txt
>
>
> I tried to use jcr component as consumer, expecting jcr observation event
> listener like behavior, but I realized that it's not supported yet. The
> current jcr component supports producer only. So, I'm considering to
> implement JcrConsumer an contribute a patch.
> My idea is as follows:
> i) the uri format is the same. e.g.
> 'jcr://user:password@repository/absolute/path/from/node'; the node path is
> used for javax.jcr.observation.ObservationManager#addEventListener(...,
> absPath, ...).
> ii) additionally, we need parameters for eventTypes, isDeep, uuid[],
> nodeTypeName[], noLocal parameters (See #addEventListener() for detail).
> For example, we may probably use somethings like
> 'jcr://user:password@repository/absolute/path/from/node?nodeTypeName=demo:news&eventTypes=3&isDeep=true.
> iii) JcrConsumer registers JCR observation event listener from the specified
> uri information.
> iv) When events notified, I think it can simply return a list of
> javax.jcr.observation.Event objects in IN message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
