[
https://issues.apache.org/jira/browse/CAMEL-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260722#comment-13260722
]
Woonsan Ko commented on CAMEL-5155:
-----------------------------------
Hi Bilgin,
> why are you calling unregisterListenerAndLogoutSession when there is no live
> session?
>
> if (!isSessionLive && isObservationListeningAllowed()) {
> unregisterListenerAndLogoutSession(); ... }
Thanks for the sharp review!
I think the call on #unregisterListenerAndLogoutSession() in the if block can
be removed.
Yes, you're right. It was unnecessary to call it for non live session.
So, the if block ("if (!isSessionLive && isObservationListeningAllowed()) { ...
}") can contain only the try block of #createSessionAndRegisterListener() call.
Kind regards,
Woonsan
> Support JCR Component as Consumer
> ---------------------------------
>
> Key: CAMEL-5155
> URL: https://issues.apache.org/jira/browse/CAMEL-5155
> Project: Camel
> Issue Type: New Feature
> Components: camel-jcr
> Affects Versions: 2.9.1
> Reporter: Woonsan Ko
> Assignee: Bilgin Ibryam
> Fix For: 2.10.0
>
> Attachments: jcr-consumer-patch.txt
>
>
> I tried to use jcr component as consumer, expecting jcr observation event
> listener like behavior, but I realized that it's not supported yet. The
> current jcr component supports producer only. So, I'm considering to
> implement JcrConsumer an contribute a patch.
> My idea is as follows:
> i) the uri format is the same. e.g.
> 'jcr://user:password@repository/absolute/path/from/node'; the node path is
> used for javax.jcr.observation.ObservationManager#addEventListener(...,
> absPath, ...).
> ii) additionally, we need parameters for eventTypes, isDeep, uuid[],
> nodeTypeName[], noLocal parameters (See #addEventListener() for detail).
> For example, we may probably use somethings like
> 'jcr://user:password@repository/absolute/path/from/node?nodeTypeName=demo:news&eventTypes=3&isDeep=true.
> iii) JcrConsumer registers JCR observation event listener from the specified
> uri information.
> iv) When events notified, I think it can simply return a list of
> javax.jcr.observation.Event objects in IN message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
