[
https://issues.apache.org/jira/browse/CAMEL-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119232#comment-15119232
]
Claus Ibsen commented on CAMEL-9539:
------------------------------------
There is a bunch of existing tests that rely on the old behavior. So there is
more changes needed for this
{code}
Failed tests:
LogCustomLoggerTest>TestSupport.runBare:58->testDefaultRegistryLogger:121
Expected: "provided.logger1.name"
but: was "provided.logger1.nameprovided.logger1.name"
LogCustomLoggerTest>TestSupport.runBare:58->testEndpointURIParametrizedLogger:104
Expected: "provided.logger2.name"
but: was "provided.logger2.nameprovided.logger2.name"
LogCustomLoggerTest>TestSupport.runBare:58->testFallbackLogger:96
Expected: "org.apache.camel.component.log.LogCustomLoggerTest"
but: was
"org.apache.camel.component.log.LogCustomLoggerTestorg.apache.camel.component.log.LogCustomLoggerTest"
LogCustomLoggerTest>TestSupport.runBare:58->testTwoRegistryLoggers:129
Expected: "irrelevant.logger.name"
but: was "irrelevant.logger.nameirrelevant.logger.name"
FromRestDefaultValueTest>TestSupport.runBare:58->testDefaultValue:41->ContextTestSupport.assertMockEndpointsSatisfied:343
mock://bye Header with name kind for message: 0. Expected: <admin> but was:
<customer>
LogDebugBodyMaxCharsOffTest>TestSupport.runBare:58->testLogBodyMaxLengthTest:53
expected:<Message[: [Body is not logged]]> but
was:<Message[[ID-davsclaus-air-51933-1453899825447-2106-1]]>
LogDebugBodyMaxCharsTest>TestSupport.runBare:58->testLogBodyMaxLengthTest:53
expected:<Message[: 01234567890123456789... [Body clipped after 20 chars, total
length is 1000]]> but
was:<Message[[ID-davsclaus-air-51933-1453899825447-2108-1]]>
LogDebugBodyMaxCharsTest>TestSupport.runBare:58->testNotClipped:69
expected:<Message[: 1234567890]> but
was:<Message[[ID-davsclaus-air-51933-1453899825447-2107-1]]>
LogDebugBodyStreamsTest>TestSupport.runBare:58->testLogBodyStreamDisabled:98
expected:<Message[: [Body is instance of java.io.InputStream]]> but
was:<Message[[ID-davsclaus-air-51933-1453899825447-2113-1]]>
LogDebugBodyStreamsTest>TestSupport.runBare:58->testLogBodyStreamDisabledByDefault:115
expected:<Message[: [Body is instance of java.io.InputStream]]> but
was:<Message[[ID-davsclaus-air-51933-1453899825447-2110-1]]>
LogDebugBodyStreamsTest>TestSupport.runBare:58->testLogBodyStreamStringSourceDisabled:47
expected:<Message[: <?xml version="1.0"?><person><name>Claus</name></person>]>
but was:<Message[[ID-davsclaus-air-51933-1453899825447-2109-1]]>
LogDebugBodyStreamsTest>TestSupport.runBare:58->testLogBodyStreamStringSourceDisabledByDefault:64
expected:<Message[: <?xml version="1.0"?><person><name>Claus</name></person>]>
but was:<Message[[ID-davsclaus-air-51933-1453899825447-2114-1]]>
LogDebugBodyStreamsTest>TestSupport.runBare:58->testLogBodyStreamStringSourceEnabled:81
expected:<Message[: <?xml version="1.0"?><person><name>Claus</name></person>]>
but was:<Message[[ID-davsclaus-air-51933-1453899825447-2111-1]]>
ManagedBrowsableEndpointTest>TestSupport.runBare:58->testBrowseableEndpoint:53
ManagedSedaEndpointTest>TestSupport.runBare:58->testSedaEndpoint:71
LogProcessorWithProvidedLoggerTest>TestSupport.runBare:58->testLogProcessorWithProvidedLogger:96
Expected: "org.apache.camel.customlogger INFO Also got Bye World"
but: was "org.apache.camel.customlogger INFO Also got Bye
Worldorg.apache.camel.customlogger INFO Also got Bye World"
LogProcessorWithProvidedLoggerTest>TestSupport.runBare:58->testLogProcessorWithRegistryLogger:86
Expected: "org.apache.camel.customlogger INFO Got Bye World"
but: was "org.apache.camel.customlogger INFO Got Bye
Worldorg.apache.camel.customlogger INFO Got Bye World"
MulticastParallelStopOnExceptionTest>TestSupport.runBare:58->testMulticastParalllelStopOnExceptionStop:71
SplitterParallelStopOnExceptionTest>TestSupport.runBare:58->testSplitParallelStopOnExceptionStop:68
ThroughPutLoggerTest.testLogStringDurationIsNotZero:45
Unexpected method call Logger.info("Received: 10 messages so far. Last group
took: 0 millis which is: ∞ messages per second. average: ∞"):
Logger.info(isNull(), startsWith("Received: 10")): expected: 1, actual: 0
Logger.info(isNull(), startsWith("Received: 20")): expected: 1, actual: 0
ValidateRegExpTest>TestSupport.runBare:58->testSendNotMatchingMessage:62 Get
a wrong exception message
ValidateSimpleRegExpTest>TestSupport.runBare:58->ValidateRegExpTest.testSendNotMatchingMessage:62
Get a wrong exception message
Tests run: 5503, Failures: 22, Errors: 0, Skipped: 4
{code}
> toString of Exchange/Message should only output id
> ---------------------------------------------------
>
> Key: CAMEL-9539
> URL: https://issues.apache.org/jira/browse/CAMEL-9539
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.16.1
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.17.0
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Change-in-exception-messages-between-2-15-3-and-2-16-1-message-bodies-are-logged-tp5776788.html
> We should avoid outputting message body etc as that may contain sensitive
> information.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
