[ 
https://issues.apache.org/jira/browse/CAMEL-11655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134817#comment-16134817
 ] 

Babak Vahdat commented on CAMEL-11655:
--------------------------------------

[~ancosen] Thanks for your feedback.

Could you please point to the bug report or ticket you're talking about so the 
real rationale behind this jira ticket becomes clear to others. I guess it's 
about this enum:

https://github.com/jsendnsca/jsendnsca/blob/master/src/main/java/com/googlecode/jsendnsca/encryption/Encryption.java

IMHO we should not restrict the API only to those three enum members NONE, XOR 
and Triple_Des just because the others don't work. If that's really the case it 
should be resolved on the jsendnsca side and we _should not_ restrict the API 
to only those 3 members just because the others don't work. IMHO Camel should 
be transparent about this. What if the Blowfish encryption gets fixed by the 
next jsendnsca release and we update to that version in Camel? Are we going to 
suddenly allow that Blowfish encryption as well and add another {{else if}} for 
that?

And what do you think about marking {{NagiosEncryptionMethod}} enum as 
deprecated? Does it make sense?

> Camel-Nagios: Use Encryption enum instead of EncryptionMethod
> -------------------------------------------------------------
>
>                 Key: CAMEL-11655
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11655
>             Project: Camel
>          Issue Type: Task
>          Components: camel-nagios
>            Reporter: Andrea Cosentino
>            Assignee: Andrea Cosentino
>             Fix For: 2.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to