[
https://issues.apache.org/jira/browse/CAMEL-11655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135599#comment-16135599
]
Babak Vahdat commented on CAMEL-11655:
--------------------------------------
{quote}
If this is something critical for you, you can revert commit and do what you
think is best for this component. It was just an attempt to avoid the death of
camel-nagios.
{quote}
[~ancosen] LOL it's not critical for me but for the community :-)
I am not convineced by your answers and kindly ask [~davsclaus] & [~lb] to
share their thoughts about this ticket as well as it's corresponding code
changes. To summurize:
- The made changes are breaking for the upcoming 2.20.0 _minor_ release if a
Camel based application already makes use of the {{encryptionMethod}} query
parameter today in production.
- IMHO Camel should be transparent and not restrict an underlying library API
just because it seems to be buggy or non-working. Bugs _should_ be resolved by
the underlying library itself and not _artificially_ through Camel by
hiding/restricting a given API. See my comments above regarding this point.
- In general, shouldn't we mark a not-recommended-to-be-used Camel API as
deprecated and encourage users to make use of the right/new API. E.g. as it's
done when some {{StringHelper}} new utiliy methods were extracted out of
{{ObjectHelper}} and the corresponding {{ObjectHelper}} methods were marked as
deprecated, see CAMEL-10389. This would make it much much easier both for Camel
code base itself as well as user's code to avoid using the legacy API. I guess
that's exactly what the {{@Deprecated}} annotation good for. I don't seem to
understand what it would be wrong with such an approach, that's, marking
{{encryptionMethod}} query parameter as deprecaterd and encourage useres to
make use of the new {{encryption}} query parameter and then support both of
them. Supporting both would not break a pre-existing application on the
production and then we could find and remove the deprecated API by Camel 3 much
easier.
WDYT?
> Camel-Nagios: Use Encryption enum instead of EncryptionMethod
> -------------------------------------------------------------
>
> Key: CAMEL-11655
> URL: https://issues.apache.org/jira/browse/CAMEL-11655
> Project: Camel
> Issue Type: Task
> Components: camel-nagios
> Reporter: Andrea Cosentino
> Assignee: Andrea Cosentino
> Fix For: 2.20.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
