[ 
https://issues.apache.org/jira/browse/CAMEL-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143502#comment-16143502
 ] 

Arno Noordover commented on CAMEL-11710:
----------------------------------------

Maybe the change isn't correct. But the reasoning was as follows:
If you have a fixed length record with lenght = 6, padding = $, trim = true and 
right-aligned unmarshalling the value foo$ gives a string "$$foo$"
I think marshalling this string should return "foo$"
Unmarshalling "foo " gives a string "$$foo ".
I think marshalling should return "foo ".
I've asked about these corner-cases in CAMEL-9476.

> trim for fixlength only trim one direction
> ------------------------------------------
>
>                 Key: CAMEL-11710
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11710
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-bindy
>    Affects Versions: 2.19.2
>            Reporter: Wilson MacGyver
>
> I was noticing for bindy my fixedlength fields, where I set trim to true is 
> no longer working
> then I spotted this
> https://github.com/apache/camel/blob/camel-2.19.2/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyFixedLengthFactory.java#L226
> the problem is
> https://github.com/apache/camel/blob/camel-2.19.2/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyFixedLengthFactory.java#L304
> trim function only trim one direction vs the bultin java string.trim()
> is this change intentional? seems like an odd choice if so. it effectively 
> means I'll have to call string trim() function on each field that I marked 
> trim=true



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to