[
https://issues.apache.org/jira/browse/CAMEL-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144463#comment-16144463
]
ASF GitHub Bot commented on CAMEL-11710:
----------------------------------------
GitHub user onders86 opened a pull request:
https://github.com/apache/camel/pull/1903
CAMEL-11710 - B option added as alignment and it works as desired whe…
…n only unmarshalling. while marshalling, default is kept as it is (which
is right alignment by default)
Perhaps This fix may be dropped and implementation of
https://issues.apache.org/jira/browse/CAMEL-7621 may be developed in the future
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/onders86/camel CAMEL-11710
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1903.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1903
----
commit 6873d2fad41a1ee1f2d0dc6ca43c6ac0a9121df1
Author: onders86 <[email protected]>
Date: 2017-08-28T22:23:54Z
CAMEL-11710 - B option added as alignment and it works as desired when only
unmarshalling. while marshalling, default is kept as it is (which is right
alignment by default)
----
> trim for fixlength only trim one direction
> ------------------------------------------
>
> Key: CAMEL-11710
> URL: https://issues.apache.org/jira/browse/CAMEL-11710
> Project: Camel
> Issue Type: Improvement
> Components: camel-bindy
> Affects Versions: 2.19.2
> Reporter: Wilson MacGyver
>
> I was noticing for bindy my fixedlength fields, where I set trim to true is
> no longer working
> then I spotted this
> https://github.com/apache/camel/blob/camel-2.19.2/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyFixedLengthFactory.java#L226
> the problem is
> https://github.com/apache/camel/blob/camel-2.19.2/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyFixedLengthFactory.java#L304
> trim function only trim one direction vs the bultin java string.trim()
> is this change intentional? seems like an odd choice if so. it effectively
> means I'll have to call string trim() function on each field that I marked
> trim=true
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
