[
https://issues.apache.org/jira/browse/CAMEL-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343807#comment-16343807
]
ASF GitHub Bot commented on CAMEL-12209:
----------------------------------------
GitHub user aldettinger opened a pull request:
https://github.com/apache/camel/pull/2198
CAMEL-12209: Proposal to fix by adding an overload
Please check
[CAMEL-12209](https://issues.apache.org/jira/browse/CAMEL-12209) out for more
details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aldettinger/camel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2198
----
commit 4fffe8fb6c9e82343617bb42a5a6922a7825d628
Author: aldettinger <aldettinger@...>
Date: 2018-01-29T18:39:00Z
CAMEL-12209: Proposal to fix by adding an overload
----
> StringHelperTest.testHumanReadableBytes() is not repeatable
> -----------------------------------------------------------
>
> Key: CAMEL-12209
> URL: https://issues.apache.org/jira/browse/CAMEL-12209
> Project: Camel
> Issue Type: Test
> Reporter: Alex Dettinger
> Priority: Minor
>
> This test expects a byte number (e.g. 1024) to be formatted into a string
> (e.g. 1.0 KB).
> The implementation is dependent upon the default locale, so this test fails,
> for instance on a french machine:
> {code:java}
> [ERROR] Run 1: StringHelperTest.testHumanReadableBytes:262 expected:<1[.]0
> KB> but was:<1[,]0 KB>
> [ERROR] Run 2: StringHelperTest.testHumanReadableBytes:262 expected:<1[.]0
> KB> but was:<1[,]0 KB>
> [ERROR] Run 3: StringHelperTest.testHumanReadableBytes:262 expected:<1[.]0
> KB> but was:<1[,]0 KB>{code}
>
> I will setup a PR to discuss this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
