[
https://issues.apache.org/jira/browse/CAMEL-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343827#comment-16343827
]
ASF GitHub Bot commented on CAMEL-12209:
----------------------------------------
davsclaus commented on a change in pull request #2198: CAMEL-12209: Proposal to
fix by adding an overload
URL: https://github.com/apache/camel/pull/2198#discussion_r164530157
##########
File path: camel-core/src/main/java/org/apache/camel/util/StringHelper.java
##########
@@ -711,17 +711,28 @@ public static boolean containsIgnoreCase(String src,
String what) {
/**
* Outputs the bytes in human readable format in units of KB,MB,GB etc.
*
+ * @param locale the locale used to format into a human readable
representation
* @param bytes number of bytes
* @return human readable output
*/
- public static String humanReadableBytes(long bytes) {
+ public static String humanReadableBytes(Locale locale, long bytes) {
int unit = 1024;
if (bytes < unit) {
return bytes + " B";
}
int exp = (int) (Math.log(bytes) / Math.log(unit));
String pre = "KMGTPE".charAt(exp - 1) + "";
- return String.format("%.1f %sB", bytes / Math.pow(unit, exp), pre);
+ return String.format(locale, "%.1f %sB", bytes / Math.pow(unit, exp),
pre);
+ }
+
+ /**
+ * Outputs the bytes in human readable format in units of KB,MB,GB etc.
+ *
Review comment:
Good idea, also maybe add a `@see` to that other method where you can
specify the exact locale to use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> StringHelperTest.testHumanReadableBytes() is not repeatable
> -----------------------------------------------------------
>
> Key: CAMEL-12209
> URL: https://issues.apache.org/jira/browse/CAMEL-12209
> Project: Camel
> Issue Type: Test
> Reporter: Alex Dettinger
> Priority: Minor
>
> This test expects a byte number (e.g. 1024) to be formatted into a string
> (e.g. 1.0 KB).
> The implementation is dependent upon the default locale, so this test fails,
> for instance on a french machine:
> {code:java}
> [ERROR] Run 1: StringHelperTest.testHumanReadableBytes:262 expected:<1[.]0
> KB> but was:<1[,]0 KB>
> [ERROR] Run 2: StringHelperTest.testHumanReadableBytes:262 expected:<1[.]0
> KB> but was:<1[,]0 KB>
> [ERROR] Run 3: StringHelperTest.testHumanReadableBytes:262 expected:<1[.]0
> KB> but was:<1[,]0 KB>{code}
>
> I will setup a PR to discuss this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
