[ 
https://issues.apache.org/jira/browse/CAMEL-12221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350156#comment-16350156
 ] 

ASF GitHub Bot commented on CAMEL-12221:
----------------------------------------

davsclaus commented on a change in pull request #2206: [CAMEL-12221] Let's 
create a camel-fhir component
URL: https://github.com/apache/camel/pull/2206#discussion_r165615028
 
 

 ##########
 File path: 
components/camel-fhir/src/test/java/org/apache/camel/component/fhir/FhirXmlDataFormatURITest.java
 ##########
 @@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.fhir;
+
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import ca.uhn.fhir.context.FhirContext;
+import org.apache.camel.Exchange;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.mock.MockEndpoint;
+import org.apache.camel.test.junit4.CamelTestSupport;
+import org.hl7.fhir.dstu3.model.Address;
+import org.hl7.fhir.dstu3.model.Base;
+import org.hl7.fhir.dstu3.model.HumanName;
+import org.hl7.fhir.dstu3.model.Patient;
+import org.hl7.fhir.instance.model.api.IBaseResource;
+import org.junit.Before;
+import org.junit.Test;
+
+public class FhirXmlDataFormatURITest extends CamelTestSupport {
+    
+    private static final String PATIENT =
+            "<Patient xmlns=\"http://hl7.org/fhir\";>"
+                    + "<name><family value=\"Holmes\"/><given 
value=\"Sherlock\"/></name>"
+                    + "<address><line value=\"221b Baker St, Marylebone, 
London NW1 6XE, UK\"/></address>"
+              + "</Patient>";
+    private MockEndpoint mockEndpoint;
+
+    @Override
+    @Before
+    public void setUp() throws Exception {
+        super.setUp();
+        mockEndpoint = resolveMandatoryEndpoint("mock:result", 
MockEndpoint.class);
+    }
+    
+    @Test
+    public void unmarshal() throws Exception {
+        template.sendBody("direct:unmarshal", PATIENT);
+        mockEndpoint.expectedMessageCount(1);
+        Exchange exchange = mockEndpoint.getExchanges().get(0);
+        Patient patient = (Patient) exchange.getIn().getBody();
+        assertTrue("Patients should be equal!", 
patient.equalsDeep(getPatient()));
+    }
+
+    @Test
+    public void marshal() throws Exception {
+        Patient patient = getPatient();
+        mockEndpoint.expectedMessageCount(1);
+        template.sendBody("direct:marshal", patient);
+        mockEndpoint.expectedMessageCount(1);
+        Exchange exchange = mockEndpoint.getExchanges().get(0);
+        InputStream inputStream = exchange.getIn().getBody(InputStream.class);
+        final IBaseResource iBaseResource = 
FhirContext.forDstu3().newXmlParser().parseResource(new 
InputStreamReader(inputStream));
+        assertTrue("Patients should be equal!", patient.equalsDeep((Base) 
iBaseResource));
+    }
+
+    private Patient getPatient() {
+        Patient patient = new Patient();
+        patient.addName(new 
HumanName().addGiven("Sherlock").setFamily("Holmes")).addAddress(new 
Address().addLine("221b Baker St, Marylebone, London NW1 6XE, UK"));
+        return patient;
+    }
+
+    protected RouteBuilder createRouteBuilder() {
+        return new RouteBuilder() {
+            public void configure() {
+                FhirContext fhirContext = FhirContext.forDstu3();
+
+                from("direct:marshal")
+                        .setProperty(FhirConstants.FHIR_CONTEXT, 
constant(fhirContext))
 
 Review comment:
   This smells, can this context not be set on the data format itself, its bad 
that end users have to setup this themselves. All the other data formats dont 
do this kind

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Let's create a camel-fhir component
> -----------------------------------
>
>                 Key: CAMEL-12221
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12221
>             Project: Camel
>          Issue Type: New Feature
>            Reporter: John Poth
>            Priority: Major
>
> Let's create a camel-fhir component based on [HAPI-FHIR|http://hapifhir.io]
> I can take care of the PR. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to