[
https://issues.apache.org/jira/browse/CAMEL-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473837#comment-16473837
]
ASF GitHub Bot commented on CAMEL-12493:
----------------------------------------
GitHub user ohr opened a pull request:
https://github.com/apache/camel/pull/2338
CAMEL-12493:make type converters and its required dependencies optional
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ohr/camel HL7-12493
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2338.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2338
----
commit a39051c542f640bd3b6829920899943d2ac78b66
Author: Christian Ohr <christian.ohr@...>
Date: 2018-05-14T06:59:42Z
CAMEL-12493:make type converters and its required dependencies optional
----
> Make additional HL7 Type Converters optional
> --------------------------------------------
>
> Key: CAMEL-12493
> URL: https://issues.apache.org/jira/browse/CAMEL-12493
> Project: Camel
> Issue Type: Improvement
> Components: camel-hl7
> Affects Versions: 2.21.0
> Reporter: christian ohr
> Priority: Major
> Fix For: 2.21.2, 2.22.0
>
>
> In Camel 2.21.0, HL7-version/event-specific type converters were added to
> camel-hl7. IMHO this was a bad idea:
> * it transitively pulls in *all* HL7 structure libraries, regardless whether
> you need them in your application or not. That's nearly 10MB. Btw, type
> converters for the newer HL7 versions 2.7, 2.8, 2.8.1 were simply
> disregarded, which would have gifted you with another ~ 7.5MB.
> * manually excluding one or more of them causes the
> AnnotationTypeConverterLoader to throw ugly NoClassDefFoundError stack traces
> in the log
> * the component documentation states that you have to manually add structure
> library dependencies (the way it should be, really)
> Proposal: remove these type converters. I think it's acceptable to do a
> simple type cast in a processor or add a manual \{{convertBodyTo(HL7Class)}}
> in the route instead.
> Opinions? (I'm happy to provide a PR :))
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
