[
https://issues.apache.org/jira/browse/CAMEL-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473953#comment-16473953
]
ASF GitHub Bot commented on CAMEL-12493:
----------------------------------------
oscerd commented on issue #2338: CAMEL-12493:make type converters and its
required dependencies optional
URL: https://github.com/apache/camel/pull/2338#issuecomment-388749972
and backported to 2.21.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make additional HL7 Type Converters optional
> --------------------------------------------
>
> Key: CAMEL-12493
> URL: https://issues.apache.org/jira/browse/CAMEL-12493
> Project: Camel
> Issue Type: Improvement
> Components: camel-hl7
> Affects Versions: 2.21.0
> Reporter: christian ohr
> Priority: Major
> Fix For: 2.21.2, 2.22.0
>
>
> In Camel 2.21.0, HL7-version/event-specific type converters were added to
> camel-hl7. IMHO this was a bad idea:
> * it transitively pulls in *all* HL7 structure libraries, regardless whether
> you need them in your application or not. That's nearly 10MB. Btw, type
> converters for the newer HL7 versions 2.7, 2.8, 2.8.1 were simply
> disregarded, which would have gifted you with another ~ 7.5MB.
> * manually excluding one or more of them causes the
> AnnotationTypeConverterLoader to throw ugly NoClassDefFoundError stack traces
> in the log
> * the component documentation states that you have to manually add structure
> library dependencies (the way it should be, really)
> Proposal: remove these type converters. I think it's acceptable to do a
> simple type cast in a processor or add a manual \{{convertBodyTo(HL7Class)}}
> in the route instead.
> Opinions? (I'm happy to provide a PR :))
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
