[
https://issues.apache.org/jira/browse/CAMEL-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543355#comment-16543355
]
ASF GitHub Bot commented on CAMEL-12650:
----------------------------------------
GitHub user lzh3636 opened a pull request:
https://github.com/apache/camel/pull/2426
CAMEL-12650 Log messages that do not match with their method function
The description of the issue:
https://issues.apache.org/jira/browse/CAMEL-12650
There are some possible copy and paste errors in the log messages (The
logging statement was copied from an old place to a new place, but the message
wasn't changed to adapt to the function of the new place. The issue report
shows the pairs of original places where the logging statements might be copied
from, and the new places that copied to) which may cause confusion when
operators are reading the log messages. I changed the logging messages to make
them more adaptive
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lzh3636/camel CAMEL-12650
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2426.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2426
----
commit c75363d046e131f56c168717edc18f12c088382c
Author: zhenhaoli <lizi422@...>
Date: 2018-07-13T15:35:48Z
CAMEL-12650 Log messages that do not match with their method function
----
> Log messages that do not match with their method function
> ---------------------------------------------------------
>
> Key: CAMEL-12650
> URL: https://issues.apache.org/jira/browse/CAMEL-12650
> Project: Camel
> Issue Type: Improvement
> Reporter: Zhenhao Li
> Priority: Minor
>
> There are some possible copy and paste errors in the log messages (The
> logging statement was copied from an old place to a new place, but the
> message wasn't changed to adapt to the function of the new place) which may
> cause confusion when operators are reading the log messages.
>
> Here is a list of the related logging statements:
>
>
> *1. log.debug("Created FTPClient [connectTimeout: {}, soTimeout: {},
> dataTimeout: {}, bufferSize: {}" + ", receiveDataSocketBufferSize: {},
> sendDataSocketBufferSize: {}]: {}";*
> *Callsites:*
> *
> org.apache.camel.component.file.remote.*{color:#205081}FTPEndpoint{color}*.createRemoteFileOperations,
> *
> org.apache.camel.component.file.remote.*{color:#205081}FtpsEndpoint{color}*.createRemoteFileOperations,
>
> *2. LOG.debug("Adding to producer service pool with key: {} for producer:
> {}", endpoint, answer);*
> *Callsites:*
> * org.apache.camel.impl.*{color:#205081}ProducerCache{color}*.doGetProducer,
> *
> org.apache.camel.impl.*{color:#205081}ConsumerCache{color}*.doGetPollingConsumer
>
> *3. LOG.debug("Trying to update the post {} with id {}",
> exchange.getIn().getBody(), this.getConfiguration().getId());*
> *Callsites:*
> *
> org.apache.camel.component.wordpress.producer.{color:#205081}*WordpressPostProducer*.{color}processUpdate,
> *
> org.apache.camel.component.wordpress.producer.{color:#205081}*WordpressUserProducer*.{color}processUpdate
>
> *4. LOG.error("Create a specific pod require specify a namespace name");*
> *Callsites:*
> *
> org.apache.camel.component.kubernetes.pods.KubernetesPodsProducer.*{color:#205081}doCreatePod{color},*
> *
> org.apache.camel.component.kubernetes.deployments.KubernetesDeploymentsProducer.*{color:#205081}doCreateDeployment{color}*
>
> *5. LOG.debug("Channel closed but no message received from address: {}",
> producer.getConfiguration().getAddress());*
> *Callsites:*
> *
> org.apache.camel.component.netty.handlers.ClientChannelHandler.*{color:#205081}channelClosed{color},*
> *
> org.apache.camel.component.netty4.handlers.ClientChannelHandler.*{color:#205081}channelInactive{color}*
>
>
> *6. LOG.trace("Delete Broker command returned the error code {}",
> ase.getErrorCode());*
> *Callsites:*
> *
> org.apache.camel.component.aws.mq.MQProducer.*{color:#205081}rebootBroker{color}*,
> *
> org.apache.camel.component.aws.mq.MQProducer.*{color:#205081}deleteBroker{color}*
>
> *7. LOG.debug("Stopping JmsReplyManager: {} from processing replies from:
> {}", replyManager, endpoint.getReplyTo() != null ? endpoint.getReplyTo() :
> "temporary queue");*
> *Callsites:*
> *
> org.apache.camel.component.rabbitmq.*{color:#205081}RabbitMQProducer{color}*.unInitReplyManager,
> *
> org.apache.camel.component.jms.*{color:#205081}JmsProducer{color}*.unInitReplyManager
>
> *8. logger.warn("Error scanning JAR for custom Camel components", e);*
> *Callsites:*
> *
> org.apache.camel.catalog.nexus.*{color:#205081}ComponentCatalogNexusRepository{color}*.addCustomCamelComponentsFromArtifact,
> *
> org.apache.camel.catalog.nexus.*{color:#205081}ConnectorCatalogNexusRepository.{color}*addCustomCamelConnectorFromArtifact
>
> *9. LOGGER.debug("Subscribe to events for queue: {}", resourceName);*
> *Callsites:*
> *
> org.apache.camel.component.atomix.client.value.{color:#205081}*AtomixValueConsumer*{color}.doStart,
> *
> org.apache.camel.component.atomix.client.queue.*{color:#205081}AtomixQueueConsumer{color}*.doStart
>
> *10. LOG.warn("TimeoutEvent received at Sip Subscription Listener");*
> *Callsites:*
> *
> org.apache.camel.component.sip.listener.{color:#205081}*SipSubscriptionListener*{color}.processTimeout,
> *
> org.apache.camel.component.sip.listener.{color:#205081}*SipPresenceAgentListener*{color}.processTimeout
>
> *11. LOGGER.debug("Executing Docker Kill Container Request");*
> *Callsites:*
> *
> org.apache.camel.component.docker.producer.DockerProducer.execute{color:#205081}*StopContainer*{color}Request,
> *
> org.apache.camel.component.docker.producer.DockerProducer.execute{color:#205081}*KillContainer*{color}Request
>
> *12. LOG.trace("Rename Droplet {} : [{}] ", dropletId, action);*
> *Callsites:*
> *
> org.apache.camel.component.digitalocean.producer.DigitalOceanDropletsProducer.change.*{color:#205081}DropletKernel{color}*,
> *
> org.apache.camel.component.digitalocean.producer.DigitalOceanDropletsProducer.{color:#205081}*renameDroplet*{color}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
