[
https://issues.apache.org/jira/browse/CAMEL-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544424#comment-16544424
]
ASF GitHub Bot commented on CAMEL-12650:
----------------------------------------
davsclaus closed pull request #2426: CAMEL-12650 Log messages that do not match
with their method function
URL: https://github.com/apache/camel/pull/2426
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/camel-core/src/main/java/org/apache/camel/impl/ConsumerCache.java
b/camel-core/src/main/java/org/apache/camel/impl/ConsumerCache.java
index 7864bf9c532..a523a09b0ce 100644
--- a/camel-core/src/main/java/org/apache/camel/impl/ConsumerCache.java
+++ b/camel-core/src/main/java/org/apache/camel/impl/ConsumerCache.java
@@ -177,7 +177,7 @@ protected synchronized PollingConsumer
doGetPollingConsumer(Endpoint endpoint, b
throw new FailedToCreateConsumerException(endpoint, e);
}
if (pooled && answer instanceof ServicePoolAware) {
- LOG.debug("Adding to producer service pool with key: {} for
producer: {}", endpoint, answer);
+ LOG.debug("Adding to consumer service pool with key: {} for
consumer: {}", endpoint, answer);
answer = pool.addAndAcquire(endpoint, answer);
} else {
boolean singleton = false;
diff --git
a/components/camel-atomix/src/main/java/org/apache/camel/component/atomix/client/value/AtomixValueConsumer.java
b/components/camel-atomix/src/main/java/org/apache/camel/component/atomix/client/value/AtomixValueConsumer.java
index ecb759eed7e..5c067bf5dec 100644
---
a/components/camel-atomix/src/main/java/org/apache/camel/component/atomix/client/value/AtomixValueConsumer.java
+++
b/components/camel-atomix/src/main/java/org/apache/camel/component/atomix/client/value/AtomixValueConsumer.java
@@ -56,7 +56,7 @@ protected void doStart() throws Exception {
.join();
- LOGGER.debug("Subscribe to events for queue: {}", resourceName);
+ LOGGER.debug("Subscribe to events for value: {}", resourceName);
this.listeners.add(this.value.onChange(this::onEvent).join());
}
diff --git
a/components/camel-aws/src/main/java/org/apache/camel/component/aws/mq/MQProducer.java
b/components/camel-aws/src/main/java/org/apache/camel/component/aws/mq/MQProducer.java
index 01517704163..c217c14a578 100644
---
a/components/camel-aws/src/main/java/org/apache/camel/component/aws/mq/MQProducer.java
+++
b/components/camel-aws/src/main/java/org/apache/camel/component/aws/mq/MQProducer.java
@@ -177,7 +177,7 @@ private void rebootBroker(AmazonMQ mqClient, Exchange
exchange) {
try {
result = mqClient.rebootBroker(request);
} catch (AmazonServiceException ase) {
- LOG.trace("Delete Broker command returned the error code {}",
ase.getErrorCode());
+ LOG.trace("Reboot Broker command returned the error code {}",
ase.getErrorCode());
throw ase;
}
Message message = getMessageForResponse(exchange);
diff --git
a/components/camel-digitalocean/src/main/java/org/apache/camel/component/digitalocean/producer/DigitalOceanDropletsProducer.java
b/components/camel-digitalocean/src/main/java/org/apache/camel/component/digitalocean/producer/DigitalOceanDropletsProducer.java
index 3c51fea0ef3..555072687cb 100644
---
a/components/camel-digitalocean/src/main/java/org/apache/camel/component/digitalocean/producer/DigitalOceanDropletsProducer.java
+++
b/components/camel-digitalocean/src/main/java/org/apache/camel/component/digitalocean/producer/DigitalOceanDropletsProducer.java
@@ -330,7 +330,7 @@ private void changeDropletKernel(Exchange exchange) throws
Exception {
}
Action action =
getEndpoint().getDigitalOceanClient().changeDropletKernel(dropletId,
exchange.getIn().getHeader(DigitalOceanHeaders.KERNEL_ID, Integer.class));
- LOG.trace("Rename Droplet {} : [{}] ", dropletId, action);
+ LOG.trace("Change Droplet {} : [{}] ", dropletId, action);
exchange.getOut().setBody(action);
}
diff --git
a/components/camel-docker/src/main/java/org/apache/camel/component/docker/producer/DockerProducer.java
b/components/camel-docker/src/main/java/org/apache/camel/component/docker/producer/DockerProducer.java
index e76cee0a932..097f4be865a 100644
---
a/components/camel-docker/src/main/java/org/apache/camel/component/docker/producer/DockerProducer.java
+++
b/components/camel-docker/src/main/java/org/apache/camel/component/docker/producer/DockerProducer.java
@@ -1019,7 +1019,7 @@ private StartContainerCmd
executeStartContainerRequest(DockerClient client, Mess
*/
private StopContainerCmd executeStopContainerRequest(DockerClient client,
Message message) {
- LOGGER.debug("Executing Docker Kill Container Request");
+ LOGGER.debug("Executing Docker Stop Container Request");
String containerId =
DockerHelper.getProperty(DockerConstants.DOCKER_CONTAINER_ID, configuration,
message, String.class);
diff --git
a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpsEndpoint.java
b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpsEndpoint.java
index 144be586183..8200e45713c 100644
---
a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpsEndpoint.java
+++
b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpsEndpoint.java
@@ -197,7 +197,7 @@ protected FTPClient createFtpClient() throws Exception {
}
if (log.isDebugEnabled()) {
- log.debug("Created FTPClient [connectTimeout: {}, soTimeout: {},
dataTimeout: {}, bufferSize: {}"
+ log.debug("Created FTPSClient [connectTimeout: {}, soTimeout: {},
dataTimeout: {}, bufferSize: {}"
+ ", receiveDataSocketBufferSize: {},
sendDataSocketBufferSize: {}]: {}",
new Object[]{client.getConnectTimeout(), getSoTimeout(),
dataTimeout, client.getBufferSize(),
client.getReceiveDataSocketBufferSize(),
client.getSendDataSocketBufferSize(), client});
diff --git
a/components/camel-kubernetes/src/main/java/org/apache/camel/component/kubernetes/deployments/KubernetesDeploymentsProducer.java
b/components/camel-kubernetes/src/main/java/org/apache/camel/component/kubernetes/deployments/KubernetesDeploymentsProducer.java
index 84bb513ffd4..28f406f34f1 100644
---
a/components/camel-kubernetes/src/main/java/org/apache/camel/component/kubernetes/deployments/KubernetesDeploymentsProducer.java
+++
b/components/camel-kubernetes/src/main/java/org/apache/camel/component/kubernetes/deployments/KubernetesDeploymentsProducer.java
@@ -149,11 +149,11 @@ protected void doCreateDeployment(Exchange exchange,
String operation) throws Ex
DeploymentSpec deSpec =
exchange.getIn().getHeader(KubernetesConstants.KUBERNETES_DEPLOYMENT_SPEC,
DeploymentSpec.class);
if (ObjectHelper.isEmpty(deploymentName)) {
LOG.error("Create a specific Deployment require specify a
Deployment name");
- throw new IllegalArgumentException("Create a specific pod require
specify a pod name");
+ throw new IllegalArgumentException("Create a specific Deployment
require specify a pod name");
}
if (ObjectHelper.isEmpty(namespaceName)) {
- LOG.error("Create a specific pod require specify a namespace
name");
- throw new IllegalArgumentException("Create a specific pod require
specify a namespace name");
+ LOG.error("Create a specific Deployment require specify a
namespace name");
+ throw new IllegalArgumentException("Create a specific Deployment
require specify a namespace name");
}
if (ObjectHelper.isEmpty(deSpec)) {
LOG.error("Create a specific Deployment require specify a
Deployment spec bean");
diff --git
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/handlers/ClientChannelHandler.java
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/handlers/ClientChannelHandler.java
index 77f498ecb76..f81fc1c8437 100644
---
a/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/handlers/ClientChannelHandler.java
+++
b/components/camel-netty4/src/main/java/org/apache/camel/component/netty4/handlers/ClientChannelHandler.java
@@ -126,7 +126,7 @@ public void channelInactive(ChannelHandlerContext ctx)
throws Exception {
// and could not return a response. We should count down to
stop waiting for a response
String address = configuration.getAddress();
if (LOG.isDebugEnabled()) {
- LOG.debug("Channel closed but no message received from
address: {}", address);
+ LOG.debug("Channel is inactive but no message received
from address: {}", address);
}
// don't fail the exchange if we actually specify to disconnect
if (!configuration.isDisconnect()) {
diff --git
a/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java
b/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java
index a28729aebaa..024daf65585 100644
---
a/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java
+++
b/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java
@@ -352,7 +352,7 @@ protected void unInitReplyManager() {
try {
if (replyManager != null) {
if (log.isDebugEnabled()) {
- log.debug("Stopping JmsReplyManager: {} from processing
replies from: {}", replyManager,
+ log.debug("Stopping RabbitMQReplyManager: {} from
processing replies from: {}", replyManager,
getEndpoint().getReplyTo() != null ?
getEndpoint().getReplyTo() : "temporary queue");
}
ServiceHelper.stopService(replyManager);
diff --git
a/components/camel-sip/src/main/java/org/apache/camel/component/sip/listener/SipPresenceAgentListener.java
b/components/camel-sip/src/main/java/org/apache/camel/component/sip/listener/SipPresenceAgentListener.java
index 75a5464d173..22648f22613 100644
---
a/components/camel-sip/src/main/java/org/apache/camel/component/sip/listener/SipPresenceAgentListener.java
+++
b/components/camel-sip/src/main/java/org/apache/camel/component/sip/listener/SipPresenceAgentListener.java
@@ -189,7 +189,7 @@ public synchronized void processResponse(ResponseEvent
responseReceivedEvent) {
public void processTimeout(javax.sip.TimeoutEvent timeoutEvent) {
if (LOG.isWarnEnabled()) {
- LOG.warn("TimeoutEvent received at Sip Subscription Listener");
+ LOG.warn("TimeoutEvent received at Sip Presence Agent Listener");
}
}
diff --git
a/components/camel-wordpress/src/main/java/org/apache/camel/component/wordpress/producer/WordpressUserProducer.java
b/components/camel-wordpress/src/main/java/org/apache/camel/component/wordpress/producer/WordpressUserProducer.java
index b6426edcf2d..7c7f9f9e991 100644
---
a/components/camel-wordpress/src/main/java/org/apache/camel/component/wordpress/producer/WordpressUserProducer.java
+++
b/components/camel-wordpress/src/main/java/org/apache/camel/component/wordpress/producer/WordpressUserProducer.java
@@ -37,7 +37,7 @@ protected User processDelete(Exchange exchange) {
}
protected User processUpdate(Exchange exchange) {
- LOG.debug("Trying to update the post {} with id {}",
exchange.getIn().getBody(), this.getConfiguration().getId());
+ LOG.debug("Trying to update the user {} with id {}",
exchange.getIn().getBody(), this.getConfiguration().getId());
return serviceUsers.update(getConfiguration().getId(),
exchange.getIn().getBody(User.class));
}
diff --git
a/platforms/camel-catalog-nexus/src/main/java/org/apache/camel/catalog/nexus/ConnectorCatalogNexusRepository.java
b/platforms/camel-catalog-nexus/src/main/java/org/apache/camel/catalog/nexus/ConnectorCatalogNexusRepository.java
index 5cf1e031753..98630d4b176 100644
---
a/platforms/camel-catalog-nexus/src/main/java/org/apache/camel/catalog/nexus/ConnectorCatalogNexusRepository.java
+++
b/platforms/camel-catalog-nexus/src/main/java/org/apache/camel/catalog/nexus/ConnectorCatalogNexusRepository.java
@@ -125,7 +125,7 @@ private void
addCustomCamelConnectorFromArtifact(NexusArtifactDto dto, URL jarUr
addConnector(dto, name, scheme, javaType, description,
csb.toString(), json[0], json[1], json[2]);
}
} catch (IOException e) {
- logger.warn("Error scanning JAR for custom Camel components", e);
+ logger.warn("Error scanning JAR for custom Camel connectors", e);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Log messages that do not match with their method function
> ---------------------------------------------------------
>
> Key: CAMEL-12650
> URL: https://issues.apache.org/jira/browse/CAMEL-12650
> Project: Camel
> Issue Type: Improvement
> Reporter: Zhenhao Li
> Priority: Minor
>
> There are some possible copy and paste errors in the log messages (The
> logging statement was copied from an old place to a new place, but the
> message wasn't changed to adapt to the function of the new place) which may
> cause confusion when operators are reading the log messages.
>
> Here is a list of the related logging statements:
>
>
> *1. log.debug("Created FTPClient [connectTimeout: {}, soTimeout: {},
> dataTimeout: {}, bufferSize: {}" + ", receiveDataSocketBufferSize: {},
> sendDataSocketBufferSize: {}]: {}";*
> *Callsites:*
> *
> org.apache.camel.component.file.remote.*{color:#205081}FTPEndpoint{color}*.createRemoteFileOperations,
> *
> org.apache.camel.component.file.remote.*{color:#205081}FtpsEndpoint{color}*.createRemoteFileOperations,
>
> *2. LOG.debug("Adding to producer service pool with key: {} for producer:
> {}", endpoint, answer);*
> *Callsites:*
> * org.apache.camel.impl.*{color:#205081}ProducerCache{color}*.doGetProducer,
> *
> org.apache.camel.impl.*{color:#205081}ConsumerCache{color}*.doGetPollingConsumer
>
> *3. LOG.debug("Trying to update the post {} with id {}",
> exchange.getIn().getBody(), this.getConfiguration().getId());*
> *Callsites:*
> *
> org.apache.camel.component.wordpress.producer.{color:#205081}*WordpressPostProducer*.{color}processUpdate,
> *
> org.apache.camel.component.wordpress.producer.{color:#205081}*WordpressUserProducer*.{color}processUpdate
>
> *4. LOG.error("Create a specific pod require specify a namespace name");*
> *Callsites:*
> *
> org.apache.camel.component.kubernetes.pods.KubernetesPodsProducer.*{color:#205081}doCreatePod{color},*
> *
> org.apache.camel.component.kubernetes.deployments.KubernetesDeploymentsProducer.*{color:#205081}doCreateDeployment{color}*
>
> *5. LOG.debug("Channel closed but no message received from address: {}",
> producer.getConfiguration().getAddress());*
> *Callsites:*
> *
> org.apache.camel.component.netty.handlers.ClientChannelHandler.*{color:#205081}channelClosed{color},*
> *
> org.apache.camel.component.netty4.handlers.ClientChannelHandler.*{color:#205081}channelInactive{color}*
>
>
> *6. LOG.trace("Delete Broker command returned the error code {}",
> ase.getErrorCode());*
> *Callsites:*
> *
> org.apache.camel.component.aws.mq.MQProducer.*{color:#205081}rebootBroker{color}*,
> *
> org.apache.camel.component.aws.mq.MQProducer.*{color:#205081}deleteBroker{color}*
>
> *7. LOG.debug("Stopping JmsReplyManager: {} from processing replies from:
> {}", replyManager, endpoint.getReplyTo() != null ? endpoint.getReplyTo() :
> "temporary queue");*
> *Callsites:*
> *
> org.apache.camel.component.rabbitmq.*{color:#205081}RabbitMQProducer{color}*.unInitReplyManager,
> *
> org.apache.camel.component.jms.*{color:#205081}JmsProducer{color}*.unInitReplyManager
>
> *8. logger.warn("Error scanning JAR for custom Camel components", e);*
> *Callsites:*
> *
> org.apache.camel.catalog.nexus.*{color:#205081}ComponentCatalogNexusRepository{color}*.addCustomCamelComponentsFromArtifact,
> *
> org.apache.camel.catalog.nexus.*{color:#205081}ConnectorCatalogNexusRepository.{color}*addCustomCamelConnectorFromArtifact
>
> *9. LOGGER.debug("Subscribe to events for queue: {}", resourceName);*
> *Callsites:*
> *
> org.apache.camel.component.atomix.client.value.{color:#205081}*AtomixValueConsumer*{color}.doStart,
> *
> org.apache.camel.component.atomix.client.queue.*{color:#205081}AtomixQueueConsumer{color}*.doStart
>
> *10. LOG.warn("TimeoutEvent received at Sip Subscription Listener");*
> *Callsites:*
> *
> org.apache.camel.component.sip.listener.{color:#205081}*SipSubscriptionListener*{color}.processTimeout,
> *
> org.apache.camel.component.sip.listener.{color:#205081}*SipPresenceAgentListener*{color}.processTimeout
>
> *11. LOGGER.debug("Executing Docker Kill Container Request");*
> *Callsites:*
> *
> org.apache.camel.component.docker.producer.DockerProducer.execute{color:#205081}*StopContainer*{color}Request,
> *
> org.apache.camel.component.docker.producer.DockerProducer.execute{color:#205081}*KillContainer*{color}Request
>
> *12. LOG.trace("Rename Droplet {} : [{}] ", dropletId, action);*
> *Callsites:*
> *
> org.apache.camel.component.digitalocean.producer.DigitalOceanDropletsProducer.change.*{color:#205081}DropletKernel{color}*,
> *
> org.apache.camel.component.digitalocean.producer.DigitalOceanDropletsProducer.{color:#205081}*renameDroplet*{color}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
