[
https://issues.apache.org/jira/browse/CAMEL-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632589#comment-16632589
]
ASF GitHub Bot commented on CAMEL-12842:
----------------------------------------
GitHub user fgiloux opened a pull request:
https://github.com/apache/camel/pull/2540
"-" dash is not a valid characters for keys in JMS headers
See Jira issue: https://issues.apache.org/jira/browse/CAMEL-12842
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fgiloux/camel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2540
----
commit 278dc03e62d73b00f6d689ad59bc31d37cdfcce8
Author: Frederic Giloux <fgiloux@...>
Date: 2018-09-28T14:23:41Z
Added dash encoding for JMS and extensibility for other connectors
commit fcb4d0ae29c842994100ae17b7f8a06505ffa92f
Author: Frederic Giloux <fgiloux@...>
Date: 2018-09-28T17:35:23Z
Makes encoding activation configuration
----
> "-" dash is not a valid characters for keys in JMS headers
> ----------------------------------------------------------
>
> Key: CAMEL-12842
> URL: https://issues.apache.org/jira/browse/CAMEL-12842
> Project: Camel
> Issue Type: Bug
> Components: camel-opentracing
> Reporter: Frederic Giloux
> Priority: Major
>
> Hi
> "-", dash is not a valid character for keys in JMS headers. This gets encoded
> in OpenTracing java-jms client: DASH = "_$dash$_"; see:
> [https://github.com/opentracing-contrib/java-jms/blob/master/opentracing-jms-common/src/main/java/io/opentracing/contrib/jms/common/JmsTextMapInjectAdapter.java]
> I am proposing to have the same approach in camel-opentracing. By doing so
> spans created by Camel can be seen under a trace created by java-jms. I have
> amended the code accordingly and will raise a pull request. I have extended
> the change to the abstract messaging class so that it also works when a peer
> is using JMS for amqp endpoint for instance. A configuration parameter allows
> to activate/deactivate encoding. If no parameter is provided the behavior is
> as before for backward compatibility.
> Regards,
> Frédéric
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
