[
https://issues.apache.org/jira/browse/CAMEL-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632888#comment-16632888
]
ASF GitHub Bot commented on CAMEL-12842:
----------------------------------------
Github user aldettinger closed the pull request at:
https://github.com/apache/camel/pull/2540
> "-" dash is not a valid characters for keys in JMS headers
> ----------------------------------------------------------
>
> Key: CAMEL-12842
> URL: https://issues.apache.org/jira/browse/CAMEL-12842
> Project: Camel
> Issue Type: Bug
> Components: camel-opentracing
> Reporter: Frederic Giloux
> Assignee: Alex Dettinger
> Priority: Major
> Fix For: 2.23.0
>
>
> Hi
> "-", dash is not a valid character for keys in JMS headers. This gets encoded
> in OpenTracing java-jms client: DASH = "_$dash$_"; see:
> [https://github.com/opentracing-contrib/java-jms/blob/master/opentracing-jms-common/src/main/java/io/opentracing/contrib/jms/common/JmsTextMapInjectAdapter.java]
> I am proposing to have the same approach in camel-opentracing. By doing so
> spans created by Camel can be seen under a trace created by java-jms. I have
> amended the code accordingly and will raise a pull request. I have extended
> the change to the abstract messaging class so that it also works when a peer
> is using JMS for amqp endpoint for instance. A configuration parameter allows
> to activate/deactivate encoding. If no parameter is provided the behavior is
> as before for backward compatibility.
> Regards,
> Frédéric
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
