[
https://issues.apache.org/jira/browse/CAMEL-18230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558929#comment-17558929
]
Alvin Tan Jian Jia commented on CAMEL-18230:
--------------------------------------------
Hi [~rhuanrcoha],
Thank you so much for your inputs! I totally agree with the pain points that
you have just raised. I am trying to obtain developer feedback on whether my
research is accurate in
# Pointing out areas that require refactoring.
# Estimating the time required for refactoring.
+What are the changes?+
I do not think that I am qualified enough to propose changes given my limited
experience to the code base. I am hoping to work with someone experienced on
the project. For the listed classes, if you feel that there could be
refactoring carried out to improve the classes, I hope to track the time
required for you to carry out the refactoring activity.
+Estimated Time+
The estimated time here is given by a model trained on all of the previous
refactoring activities on Camel, taking into account the refactored class
dependencies, line of code involved, number of methods involved, complexity of
code etc. It is a rough estimate here estimating the time required for
refactoring.
For example, in the past commit 4b2c7bf93c94461133dd4a58122a25a9b90f48a4,
refactoring is carried out that involved 29 dependencies involving 4 classes
and 10 total refactored lines.
The specifics of the research can be found at
[https://github.com/alvintanjianjia/SoftwareRemodularization.] Please let me
know if you require more details, or are there any areas that I can help to
make this process easier.
Thank you.
Regards,
Alvin
> Potential Refactoring
> ---------------------
>
> Key: CAMEL-18230
> URL: https://issues.apache.org/jira/browse/CAMEL-18230
> Project: Camel
> Issue Type: Improvement
> Reporter: Alvin Tan Jian Jia
> Priority: Minor
> Labels: refactor
> Attachments: Camel_camel-3.7.0.csv
>
>
> *Summary*
> I have identified a few classes with refactoring potential, specifically
> error handlers . The issue was refactored once on Nov 12, 2020 along with
> other classes in commit d1be1a6bbc11d87d19a52ffcda25f0187a4b4055. Given the
> duration of the last refactoring, could it be possible to improve the overall
> package of error handlers further? I am probably not qualified and
> experienced enough to point out the exact code needs to be refactored, given
> my limited knowledge of the project and codebase.
> *Urgency*
> Low priority. For maintenance of code in the long run.
> Hi,
> I am currently doing some research on Estimating Time Taken for Software
> Refactoring. Camel is one of my case studies being a highly popular project.
> Would appreciate your kind feedback on the appropriateness of the estimated
> time to refactor.
> I am specifically looking at potential for refactoring, such as breaking
> functions that are too long into shorter functions, or to remove code
> duplication. Would you agree that there could be some modification to the
> code to make it better in the listed classes? And if so, is the estimated
> time appropriate to carry out the improvement? I will be grateful for any
> help you can provide.
> # ErrorHandlerRefReifier.java - 2 hours
> # ErrorHandlerReifier.java - 3 hours
> # NoErrorHandlerReifier.java - 1 hour
> # DefaultErrorHandlerReifier.java - 2 hours
> # DeadLetterChannelReifier.java - 1 hour
> # ErrorHandlerHelper.java - 2 hours
> # DefaultErrorHandlerProperties.java - 4 hours
>
> The attached csv file contains the other recommendations from my research.
> Thank you once again for any help you can provide.
>
> Regards,
> Alvin
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
