Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1008#discussion_r121982890
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/TableDictionaryGenerator.java
---
@@ -115,7 +115,10 @@ public Integer size(DictionaryMessage key) {
}
public void updateGenerator(CarbonDimension dimension) {
- columnMap.put(dimension.getColumnId(),
- new IncrementalColumnDictionaryGenerator(dimension, 1));
+ // reuse dictionary generator
+ if (null == columnMap.get(dimension.getColumnId())) {
+ columnMap.put(dimension.getColumnId(),
--- End diff --
lock is required to be taken on columnMap. with double checking, otherwise
still parallel intialization is possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
