Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1008#discussion_r122119776
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java
---
@@ -51,10 +51,12 @@ public void
initializeGeneratorForTable(DictionaryMessage key) {
CarbonDimension dimension = carbonTable.getPrimitiveDimensionByName(
key.getTableUniqueName(), key.getColumnName());
// initialize TableDictionaryGenerator first
- if (tableMap.get(key.getTableUniqueName()) == null) {
- tableMap.put(key.getTableUniqueName(), new
TableDictionaryGenerator(dimension));
- } else {
- tableMap.get(key.getTableUniqueName()).updateGenerator(dimension);
+ synchronized (tableMap) {
+ if (tableMap.get(key.getTableUniqueName()) == null) {
--- End diff --
double check should be done before acquiring lock. other wise all reads
block each other
if (tableMap.get(key.getTableUniqueName()) == null) {
syncronized(tableMap){
if (tableMap.get(key.getTableUniqueName()) == null) {
}
}
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
