Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1079#discussion_r125152345
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
 ---
    @@ -102,9 +109,15 @@ public void update(Object value) {
             break;
           case DECIMAL:
             BigDecimal decimalValue = DataTypeUtil.byteToBigDecimal((byte[]) 
value);
    -        decimal = decimalValue.scale();
    -        BigDecimal val = (BigDecimal) min;
    -        nonExistValue = (val.subtract(new BigDecimal(1.0)));
    +        if (isFirst) {
    --- End diff --
    
    I think this `isFirst` is required. just check null for max or min here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to