Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1079#discussion_r125152956
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
@@ -1042,12 +1144,17 @@ public static FilterExecuter getFilterExecuterTree(
* @param dimension
* @param dimColumnExecuterInfo
*/
- public static void prepareKeysFromSurrogates(DimColumnFilterInfo
filterValues,
+ public static void prepareKeysFromSurrogates(ColumnFilterInfo
filterValues,
SegmentProperties segmentProperties, CarbonDimension dimension,
- DimColumnExecuterFilterInfo dimColumnExecuterInfo) {
- byte[][] keysBasedOnFilter = getKeyArray(filterValues, dimension,
segmentProperties);
- dimColumnExecuterInfo.setFilterKeys(keysBasedOnFilter);
-
+ DimColumnExecuterFilterInfo dimColumnExecuterInfo, CarbonMeasure
measures,
+ MeasureColumnExecuterFilterInfo msrColumnExecuterInfo) {
+ if (null != measures) {
--- End diff --
I don't think this `if ` check is required. just pass dimension and measure
to the method 'getKeyArray'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
