Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1079#discussion_r125153772
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -186,12 +314,60 @@ private boolean isScanRequired(byte[] blkMaxVal,
byte[] blkMinVal, byte[][] filt
return isScanRequired;
}
+ private boolean isScanRequired(byte[] maxValue, byte[] minValue,
byte[][] filterValue,
+ DataType dataType) {
+ for (int i = 0; i < filterValue.length; i++) {
+ if (filterValue[i].length == 0 || maxValue.length == 0 ||
minValue.length == 0) {
+ return isScanRequired(maxValue, minValue, filterValue);
+ } else {
+ switch (dataType) {
--- End diff --
Use existing methods of DataTypeUtil for conversions. And use comparator
which is used in applyFilter method here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
