Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1079#discussion_r125154292
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
@@ -76,24 +99,25 @@ public static Comparator
getComparatorByDataType(DataType dataType) {
static class DoubleComparator implements Comparator<Object> {
@Override public int compare(Object key1, Object key2) {
- double result = (double) key1 - (double) key2;
- if (result < 0) {
+ double key1Double1 = (double)key1;
--- End diff --
Why need to change this logic? old logic seems fine right
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
