Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1079#discussion_r125190884
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
@@ -180,9 +185,27 @@ private static FilterExecuter createFilterExecuterTree(
* @return
*/
private static FilterExecuter getIncludeFilterExecuter(
- DimColumnResolvedFilterInfo dimColResolvedFilterInfo,
SegmentProperties segmentProperties) {
-
- if (dimColResolvedFilterInfo.getDimension().isColumnar()) {
+ DimColumnResolvedFilterInfo dimColResolvedFilterInfo,
+ MeasureColumnResolvedFilterInfo msrColResolvedFilterInfo,
+ SegmentProperties segmentProperties) {
+ if (null != msrColResolvedFilterInfo &&
msrColResolvedFilterInfo.getMeasure().isColumnar()) {
+ CarbonMeasure measuresFromCurrentBlock = segmentProperties
+
.getMeasureFromCurrentBlock(msrColResolvedFilterInfo.getMeasure().getColumnId());
+ if (null != measuresFromCurrentBlock) {
+ // update dimension and column index according to the dimension
position in current block
+ MeasureColumnResolvedFilterInfo msrColResolvedFilterInfoCopyObject
=
+ msrColResolvedFilterInfo.getCopyObject();
+
msrColResolvedFilterInfoCopyObject.setMeasure(measuresFromCurrentBlock);
+
msrColResolvedFilterInfoCopyObject.setColumnIndex(measuresFromCurrentBlock.getOrdinal());
+
msrColResolvedFilterInfoCopyObject.setType(measuresFromCurrentBlock.getDataType());
+ return new IncludeFilterExecuterImpl(null,
msrColResolvedFilterInfoCopyObject,
+ segmentProperties, true);
+ } else {
+ return new
RestructureIncludeFilterExecutorImpl(dimColResolvedFilterInfo,
+ msrColResolvedFilterInfo, segmentProperties, true);
+ }
+ }
--- End diff --
No, This whole block belongs to Measure. Line 220 points to Restructure in
case of dimentions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
