Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1362#discussion_r143614716
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -206,6 +199,7 @@ public static ColumnPage newPage(TableSpec.ColumnSpec 
columnSpec, DataType dataT
           }
         } else {
           switch (dataType) {
    +        case BOOLEAN:
    --- End diff --
    
    It is better to add a `newBooleanPage`, otherwise `newBytePage` internal 
will store the data type as byte instead of boolean


---

Reply via email to